search

gajus / lightship

Abstracts readiness, liveness and startup checks and graceful shutdown of Node.js services running in Kubernetes.
Other
515 stars 33 forks source link

fix: override module to "CommonJS" for cjs distribution #68

Closed fooku18 closed 3 months ago

fooku18 commented 10 months ago

see https://github.com/gajus/lightship/issues/67

newerton commented 5 months ago

@fooku18 resolves the conflict and updates the PR

dariusdev commented 3 months ago

 @gajus can you give some love for us here or this project is deprecated?

gajus commented 3 months ago

This is already in the tsconfig, so I don't see what this PR is trying to accomplish?

https://github.com/gajus/lightship/blob/0a57cc6d128f898c55a4877face8fadb50b89422/tsconfig.build-cjs.json#L3

dariusdev commented 3 months ago

All commonJs users cant use this package. I guess this PR should be related with https://github.com/gajus/lightship/issues/69