search

gajus / puppeteer-proxy

Proxies Puppeteer Page requests.
Other
197 stars 24 forks source link

Allow to specifiy proxy URL for HTTP and HTTPS #18

Closed Kikobeats closed 3 years ago

Kikobeats commented 3 years ago

Hello,

Some proxy providers have a different port for HTTP and HTTPS connections

https://github.com/gajus/puppeteer-proxy/blob/f73ecf0eaaef9f18bcd5768739c683a202146e31/src/routines/proxyRequest.js#L123

what if the library exposes a way to provide both things?

Something like that:

agent = {
  http: new HttpProxyAgent(proxyUrl.http || proxyUrl),
  https: new HttpsProxyAgent(proxyUrl.https || proxyUrl)
};
gajus commented 3 years ago

Of course. Seems like a valid addition.

gajus commented 3 years ago

:tada: This issue has been resolved in version 2.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: