search

gajus / react-youtube-player

React component that encapsulates YouTube IFrame Player API and exposes player controls using the component properties.
Other
40 stars 17 forks source link

playbackState change has no effect, even in demo #11

Closed mistercoffee66 closed 7 years ago

mistercoffee66 commented 7 years ago

Hi, I'm running your demo.

react-youtube-player $ npm run build

> react-youtube-player@0.3.3 build /Users/rover/Sites/react-youtube-player
> pragmatist --es5 build

(node:6705) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[13:35:51] Starting 'pragmatist:build'...
[13:35:51] Starting 'pragmatist:build:clean'...
[13:35:51] Finished 'pragmatist:build:clean' after 9.31 ms
[13:35:51] Starting 'pragmatist:build:copy'...
[13:35:51] Finished 'pragmatist:build:copy' after 45 ms
[13:35:51] Starting 'pragmatist:build:compile'...
[13:35:52] Finished 'pragmatist:build:compile' after 426 ms
[13:35:52] Finished 'pragmatist:build' after 485 ms
react-youtube-player $  npm run demo

> react-youtube-player@0.3.3 demo /Users/rover/Sites/react-youtube-player
> start-storybook -p 9001

React Storybook started on => http://localhost:9001/

webpack built f274b47ed3fffc595e6c in 3518ms
webpack building...
webpack built f274b47ed3fffc595e6c in 117ms

expected behavior: clicking 'component mounted with playbackState set to "playing"' should load a video and play it.

actual behavior: video loads but does not play, regardless of what playbackState I select. I verified in React DevTools that the playbackState is getting updated properly. If I load it with 'playing' state already selected (http://localhost:9001/?selectedKind=react-youtube-player&selectedStory=component%20mounted%20with%20playbackState%20set%20to%20%22playing%22&full=0&down=1&left=1&panelRight=0) it does play, but as soon as I make another selection, everything is paused no matter what.

$ node -v
v6.9.4
$  npm -v
3.10.10
gajus commented 7 years ago

@samelwitt I am out of capacity to take a look at this any time soon. However, should you have time to investigate the issue and raise a PR to address it, I will dedicate time to review it and release it promptly.

gajus commented 7 years ago

Fixed. Sorry for the inconvenience.

mistercoffee66 commented 7 years ago

@gajus Thank you!