search

gajus / react-youtube-player

React component that encapsulates YouTube IFrame Player API and exposes player controls using the component properties.
Other
40 stars 17 forks source link

Super basic working tests to base a testing suite on #8

Closed hellofishy closed 8 years ago

hellofishy commented 8 years ago

Not trying to get the Bounty as I know these tests do not cover everything possible, but I thought I might as well merge seeing as there were no tests before.

gajus commented 8 years ago

@hellofishy have you seen that @PlasmaPower has literally submitted a PR yesterday?

https://github.com/gajus/react-youtube-player/pull/7

gajus commented 8 years ago

I think that in this particular case, @PlasmaPower solution (using headless browser) is more appropriate. With that in mind, I will close this PR.

That said, if you are looking to practise raising PRs or writing test cases, have a look at https://github.com/gajus/youtube-player. It requires about the same work that is in #7. I would be happy to give you feedback through the PR process.

hellofishy commented 8 years ago

Thanks @gajus. I will take a look and will ask questions when I come across them.

Thanks, Zack