search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Consider dropping dependency on Lodash #14

Closed gaearon closed 8 years ago

gaearon commented 8 years ago

Lodash isn't a tiny library so it's better not to drag it completely just for a couple of functions. foreach, isEmpty, filter, and isUndefined are easy to replace with plain JS constructs. If there is a real reason for using Lodash implementations, it would still be better to import individual functions.

Finally, what do you think about making immutable a peer dependency? We certainly never want to have a duplicate immutable, and this library doesn't make sense unless you're already using immutable, so peer looks like the right solution to avoid duplicate installations.

gaearon commented 8 years ago

Let's discuss in #27.

gaearon commented 8 years ago

Whoops, I meant #15