search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Remove dependencies on lodash and pluralize #15

Closed gaearon closed 8 years ago

gaearon commented 8 years ago

I only now realized that these are dependencies. In general we try to pick projects with as least dependencies as possible for our Ecosystem packages. I don't think Lodash dependency is justified here, as it increases bundle size for a few utility functions.

Unfortunately I couldn't figure out how to fix the linter to not complain about usage of built-in functions. I understand if you don't want to take this, but unfortunately we can't officially recommend a package that brings in the whole Lodash for the sake of combineReducers().

gajus commented 8 years ago

Ignore the merge conflicts – did not see the PR before removing the pluralize dependency. Will fix the merge conflicts myself.

gajus commented 8 years ago

Thank you for the PR @gaearon.

gajus commented 8 years ago

Version 3.0.2 released and incorporates all these changes.

mxstbr commented 8 years ago

Fresh install of 3.0.2, getting the following error:

/~/redux-immutable/dist/combineReducers.js
Module not found: Error: Cannot resolve module 'lodash/forEach'

EDIT: #17