search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Updating Redux doc links and improving link reuse #47

Closed igorsantos07 closed 7 years ago

gajus commented 7 years ago

I prefer not to. This way the links get lost.

Thank you for the suggestion.

igorsantos07 commented 7 years ago

What do you mean by "get lost"? They're clearly defined at the markdown footer, just like many (most?) md documentation files.

Otherwise it's very easy to get links wrong, or update in a place and not in another one - DRY, I bet you use this in your code as well :) I should also point I changed that because there's a broken link in the doc, that was harder to fix because I had to look for it again and again around the file. And that broken link is fixed in this PR as well.

Reconsider this ;)

gajus commented 7 years ago

I should also point I changed that because there's a broken link in the doc, that was harder to fix because I had to look for it again and again around the file. And that broken link is fixed in this PR as well.

Fixed in https://github.com/gajus/redux-immutable/commit/91e5252094f15a9758c28e637d7c335b7945e245

Thank you

What do you mean by "get lost"? They're clearly defined at the markdown footer, just like many (most?) md documentation files.

Unlike code, markdown files do not have a linter to find unused links.

(Coincidentally, I was working on that some time ago. https://github.com/gajus/gitdown)

igorsantos07 commented 7 years ago

And you find unused links worse than having to fix links more than once in code? Ok...

Igor Santos -- Desenvolvedor Web [enviado do meu celular]

On Jan 20, 2017 15:58, "Gajus Kuizinas" notifications@github.com wrote:

I should also point I changed that because there's a broken link in the doc, that was harder to fix because I had to look for it again and again around the file. And that broken link is fixed in this PR as well.

Fixed in 91e5252 https://github.com/gajus/redux-immutable/commit/91e5252094f15a9758c28e637d7c335b7945e245

Thank you

What do you mean by "get lost"? They're clearly defined at the markdown footer, just like many (most?) md documentation files.

Unlike code, markdown files do not use a linter to find unused links.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gajus/redux-immutable/pull/47#issuecomment-274137061, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgfS0hkgwLfcX9OLsvrrl31ay1jY9shks5rUPXZgaJpZM4KkHN6 .