gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Update for RequireJS compatibility #50

Closed k2s closed 7 years ago

k2s commented 7 years ago

current release 3.0.10 is not loadable by RequireJS

from http://requirejs.org/docs/api.html#jsfiles

RequireJS also assumes by default that all dependencies are scripts, so it does not expect to see a trailing ".js" suffix on module IDs. RequireJS will automatically add it when translating the module ID to a path

created based on discussion here https://github.com/aurelia/cli/issues/428

gajus commented 7 years ago

I am closing this as it has not received more attention.

Thank you for the contribution.

zewa666 commented 7 years ago

@gajus what would be necessary to get this merged? As is the module simply doesn't support AMD loaders properly which is sad for requirejs users. Also the fix would introduce no harm to cjs style