search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Add TypeScript typings #56

Closed sebald closed 7 years ago

sebald commented 7 years ago

Hi @gajus can I interest you in some typings for TypeScript? 🙂

It would be nice for the TypeScript users, if the definition file would be included directly in the repository. Although somebody already published typings to @types/redux-immutable the typings are wrong/do not catch every error.

Having typings directly in the module is good for DX and keep the typings in sync.

gajus commented 7 years ago

Thank you @sebald for the contribution.

It is always a good idea to check for existing PRs before creating a PR.

https://github.com/gajus/redux-immutable/issues?utf8=%E2%9C%93&q=%20TypeScript%20

The short story is – I don't use TypeScript, don't support its use, and don't want to have it as part of the project (because it would restrict me making updates without also needing to update TypeScript annotations that I am not even using).