search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

Immutable v4 compatibility #61

Closed Velenir closed 7 years ago

Velenir commented 7 years ago

Closes #46

Also I would like to propose separating immutable dependency into peerDependencies and devDependencies:

"peerDependencies": {
  "immutable": "^3.8.1 || ^4.0.0-rc.1"
},
"devDependencies": {
  "immutable": "^3.8.1 || ^4.0.0-rc.1"
}

That way if a user's project at large uses immutable@^4, redux-immutable won't try to pull in immutable@3.8.1 as a local dependency, but rather import from the project. Avoids bloating up bundle size.

Conditional devDependencies avoids npm warnings when switching between immutable versions in development. 3.8.1 is installed by default.

gajus commented 7 years ago

This looks good. Is is ready to be merged?

Velenir commented 7 years ago

If you agree that immutable dependency should be separated as I proposed, then I'll quickly add a commit with that. Or would you prefer a separate PR?

gajus commented 7 years ago

If you agree that immutable dependency should be separated as I proposed, then I'll quickly add a commit with that.

:+1: go for it, this PR is fine.

Velenir commented 7 years ago

Good to go :smile:

gajus commented 7 years ago

Thank you

Velenir commented 7 years ago

Thank you for such a useful module.

jeffchan commented 6 years ago

@gajus Thanks for the package! We upgraded to Immutable v4 and noticed that this change, while merged, isn't published to NPM yet. Is it possible to publish it?

jeffchan commented 6 years ago

Nevermind my comment. It is indeed already published as v4.

andrewmclagan commented 6 years ago

Would people consider bumping this to 

"peerDependencies": {
  "immutable": "^3.8.1 || ^4.0.0-rc.9"
},
"devDependencies": {
  "immutable": "^3.8.1 || ^4.0.0-rc.9"
}