search

gajus / redux-immutable

redux-immutable is used to create an equivalent function of Redux combineReducers that works with Immutable.js state.
Other
1.88k stars 82 forks source link

please offer a browser built version #68

Closed lovetingyuan closed 7 years ago

lovetingyuan commented 7 years ago

you should include a browser built file in your dist directory with an umd format, thanks

gajus commented 7 years ago

I don't see a good reason to do that.

lovetingyuan commented 7 years ago

it is a convention，because the lib is not only used for ssr but also for browsers most popular libs usually offer an umd build version even an es one now, your lib can not run without building tools(webpack, browserify...), thanks

easingthemes commented 6 years ago

Some of the reasons:

  1. Fast demo setup
  2. Create and share examples in jsfiddle/codepen.
  3. Create app without build tools
  4. Play with it in browser console

I've rebuilt the whole react/redux/thunk/reselect/immutablejs .... app in one file, and this was the only library not available trough cdn.

I can open PR, if you change your mind. Thanks

gajus commented 6 years ago

Just 👍 the issue. If there is enough demand, I will do it.

So far you are the only two people to voice the requirement in 2 years this library existed.

vsnikkil commented 6 years ago

@gajus this is essential for old development environments (e.g., when using requirejs). I can do PR if I have time to finalize my rollup configuration

gajus commented 6 years ago

@gajus this is essential for old development environments (e.g., when using requirejs). I can do PR if I have time to finalize my rollup configuration

Sorry, no plan to support it.