gajus / slonik

A Node.js PostgreSQL client with runtime and build time type safety, and composable SQL.
Other
4.57k stars 139 forks source link

Incorrect Datatype of QueryContextType.queryInputTime #81

Closed dennismphil closed 3 years ago

dennismphil commented 5 years ago

Description

The datatype of QueryContextType.queryInputTime should be bigint instead of number based on the implementation in executeQuery.js.

// types.js
export type QueryContextType = {|
  ...
  +queryInputTime: number,
  ...
|};
// executeQuery.js
...
...
const queryInputTime = process.hrtime.bigint();
...
...

Thank you for all the effort put into building this library.

bitmoji

gajus commented 5 years ago

Flow does not support bigint at the moment.

https://github.com/facebook/flow/issues/6639

gajus commented 3 years ago

We are not using Flow anymore.