Use lodash method imports & replace some with native functions

realityking commented 3 years ago

I know there's been some recent bad experience with lodash refactors but I hope this more conservative approach here is safer.

The PR does 2 things:

It uses the lodash per method imports. This loads less code but more importantly it makes it easier to see what parts of lodash are actually used by table
It uses the native functions String.prototype.trimEnd and Object.values. Both are available now that table requires Node.js 10

Some other things might be possible but I think they're better kept for follow-up PRs.

Note I did not use the per-method packages as they're deprecated and actually hurt deduplication. They also load more code than this approach.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 216

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/truncateTableData.js	0	1	0.0%
src/createStream.js	1	3	33.33%
<!--	Total:	16	19	84.21%	-->

gajus commented 3 years ago

realityking commented 3 years ago

My bad, I didn't see that. I've opened #127 for the other two commits in this branch as they still make sense.