search

gajus / table

Formats data into a string table.
Other
904 stars 76 forks source link

Problems in typings #151

Closed yankeeinlondon closed 3 years ago

yankeeinlondon commented 3 years ago
2021-04-19_12-22-14

Upgraded to 6.3.0 and can no longer build using Typescripts tsc compiler due to upstream issues in Table. When publishing library code I would strongly suggest using the strictest setting in Typescript (not sure if that's what the issue is but I suspect that's why you didn't see it).

It's possible -- but unlikely -- that this issue is on my end. I will roll back to prior release for now.

yankeeinlondon commented 3 years ago

ping me if you want to pair on this

gajus commented 3 years ago

@nam-hle

nam-hle commented 3 years ago
2021-04-19_12-22-14

Upgraded to 6.3.0 and can no longer build using Typescripts tsc compiler due to upstream issues in Table. When publishing library code I would strongly suggest using the strictest setting in Typescript (not sure if that's what the issue is but I suspect that's why you didn't see it).

It's possible -- but unlikely -- that this issue is on my end. I will roll back to prior release for now.

Hi @ksnyde, the problem is not about strict mode, I turned on all strict settings. It’s from I did not turn on lib check (skipLibCheck) when testing in the user land. I also fixed it in #153.

Cheers.

nam-hle commented 3 years ago

This issue is fixed in #153. Please close this.

yankeeinlondon commented 3 years ago

Thanks for doing this. My table-based life has improved already. :)