Improve Typescript implementation - Githubissues

gajus / table

Formats data into a string table.

Other

904 stars 76 forks source link

Improve Typescript implementation #152

Closed realityking closed 3 years ago

realityking commented 3 years ago

Very cool to see #147 merged. I'd like to offer a few improvements

This removes the added src folder under dist, keeping a flatter file structure by compiling only the tests
Includes the generated validators into type checking by providing a .d.ts file
Uses ts-node to run tests directly of the Typescript code
Skip generating source maps when building (they weren't shipped before but this makes it a bit more obvious what's going on)

It might be easier to review this commit by commit.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 284

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 99.786%

Totals
Change from base Build 282:	-0.2%
Covered Lines:	345
Relevant Lines:	345

💛 - Coveralls

nam-hle commented 3 years ago

Great work, @realityking. Thanks a lot.

gajus commented 3 years ago

:tada: This PR is included in version 6.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: