[refactor] Consistency schema and typing - Githubissues

gajus / table

Formats data into a string table.

Other

904 stars 76 forks source link

[refactor] Consistency schema and typing #165

Closed nam-hle closed 3 years ago

nam-hle commented 3 years ago

columnDefault and columnCount are required in API interfaces but not in the schema. This PR makes it requirable, the errors will be thrown in validating step instead of processing one. The remain difference between typing and schema is about streamConfig.columnDefault.width.

Also, remove row assertion because it already checks in validateTableData.ts file.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 328

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 325:	0.0%
Covered Lines:	341
Relevant Lines:	341

💛 - Coveralls

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 334

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 332:	0.0%
Covered Lines:	338
Relevant Lines:	338

💛 - Coveralls

gajus commented 3 years ago

:tada: This PR is included in version 6.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: