search

gajus / table

Formats data into a string table.
Other
893 stars 77 forks source link

Replace `lodash.clonedeep` and `lodash.truncate` to `lodash` #186

Closed Semigradsky closed 2 years ago

Semigradsky commented 2 years ago

See https://lodash.com/per-method-packages for reasons for change.

I can send PR.

gajus commented 2 years ago

I believe we just need to revert this PR

https://github.com/gajus/table/pull/136

gajus commented 2 years ago

@ljharb

ljharb commented 2 years ago

Reverting that PR would be a very bad idea.

The comment saying they will be removed in v5 was made THREE years ago. When and if v5 ever arrives, it's worth re-evaluating, but until then, v4 is the final version of lodash.

Either way, applications already should, and must, configure their bundler to dedupe lodash packages. It's not sustainable to go file issues throughout the ecosystem and try to persuade every package author to do the same thing - some authors are going to go one way, some the other - so you'll always have to handle it at the app level.

Deduplication and bundle size is a problem easily solved at the app level; CVE noise is a problem that causes harm to every single part of the ecosystem. My suggestion is to keep things the same, to avoid the very problem that #136 fixed.