Open bmish opened 1 year ago
Totals | |
---|---|
Change from base Build 3374277795: | 0.0% |
Covered Lines: | 642 |
Relevant Lines: | 642 |
Hi @bmish, thanks for contributing!
So this change is a kind of breaking change, isn't it?
Nope, not a breaking change. It allows read-only arrays but does not require them. It expands the allowed input.
Ping? Again, this is not a breaking change.
Ping?
This is the minimum set of changes needed to allow a readonly array to be passed as input to the public
table()
function, in addition to regular arrays (backward compatible).Some users may prefer to declare their arrays as readonly, or use functions/libraries that return readonly arrays when generating the table data. This change improves compatibility for such users.
It's also generally good practice for us to enforce that we do not modify input parameters.
Potential follow-up changes:
spanningCells
option that could be changed to use a readonly array. This would require a minor change to avoid mutating the input array by cloning it first.References: