fix: Generate larger tables more quickly

gajus / table

Formats data into a string table.

Other

894 stars 77 forks source link

fix: Generate larger tables more quickly #224

Closed m-allanson closed 5 months ago

m-allanson commented 6 months ago

Testing locally, this change dropped the time taken for a large (3256 line) table from ~12 seconds to ~0.25 seconds.

Previously table was recreating the rowIndexMapping for each row. It looks like the mapping is the same each time, so I've moved the work up to happen only once, with the result stored in spanningCellManager.

Refs #223

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8038857083

Details

6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 3374277795:	0.0%
Covered Lines:	642
Relevant Lines:	642

💛 - Coveralls

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 6.8.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: