BREAKING CHANGE: Drop support for NodeJS v6

favna commented 5 years ago

NodeJS version 6.0 has been EOL'd since April 30th 2019 and should no longer be fully supported. However introducing such breaking changes should come with a major version upgrade which would mean version 6.0.0. You can view the NodeJS release schedule and history on NodeJS's GitHub here.

This PR officially drops supports for NodeJS v6 and if I understand semantic-release properly the BREAKING CHANGE: prefix will trigger a major version upgrade of the packge, to version 6.0.0.

Anyone who will then want to continue using NodeJS v6 (for imho god knows what reason, you're missing out on so much) can lock their installation to v5 with "table": "^5" in their package.json while everyone else can just use the latest and best supported version with the least risks of security and/or performance issues.

List of changes:

Upgraded dependencies
I've adjusted the Travis configuration to test against Node 8 (current maintenance LTS), Node 10 (current LTS) and Node 12 (current Latest).
Babel configuration is also adjusted to target Node 10.
Engines field in package.json got the same treatment, but targeting Node 8.
I've also removed the .npmignore file, instead opting to use the better way of specifying which files to publish in package.json using the files field. It's far easier to specify which files to publish than to specify which files not to publish as the latter falls over the moment you add a new file while the former does not.
As for the changes to .gitignore, I've added yarn.lock and package-lock.json. I'm going to assume you have your local environment set up to either not generate a lock file or you always remove it pre-commit but for forkers not ignoring lock files when you explicitly do not want them on Git is really frustrating.

Signed-off-by: Jeroen Claassens support@favware.tech

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.668%

Totals
Change from base Build 174:	0.0%
Covered Lines:	169
Relevant Lines:	230

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.668%

Totals
Change from base Build 174:	0.0%
Covered Lines:	169
Relevant Lines:	230

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.668%

Totals
Change from base Build 174:	0.0%
Covered Lines:	169
Relevant Lines:	230

💛 - Coveralls

gajus commented 5 years ago

Thank you for the PR. However, as it is, it bundles many changes into one for no good reason. I will update table to support Node.js v10 in the near future.

gajus / table