gajus / table

Formats data into a string table.
Other
904 stars 76 forks source link

BREAKING CHANGE: Drop support for NodeJS v6 #99

Closed favna closed 5 years ago

favna commented 5 years ago

NodeJS version 6.0 has been EOL'd since April 30th 2019 and should no longer be fully supported. However introducing such breaking changes should come with a major version upgrade which would mean version 6.0.0. You can view the NodeJS release schedule and history on NodeJS's GitHub here.

This PR officially drops supports for NodeJS v6 and if I understand semantic-release properly the BREAKING CHANGE: prefix will trigger a major version upgrade of the packge, to version 6.0.0.

Anyone who will then want to continue using NodeJS v6 (for imho god knows what reason, you're missing out on so much) can lock their installation to v5 with "table": "^5" in their package.json while everyone else can just use the latest and best supported version with the least risks of security and/or performance issues.

List of changes:

Signed-off-by: Jeroen Claassens support@favware.tech

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176


Totals Coverage Status
Change from base Build 174: 0.0%
Covered Lines: 169
Relevant Lines: 230

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176


Totals Coverage Status
Change from base Build 174: 0.0%
Covered Lines: 169
Relevant Lines: 230

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 176


Totals Coverage Status
Change from base Build 174: 0.0%
Covered Lines: 169
Relevant Lines: 230

💛 - Coveralls
gajus commented 5 years ago

Thank you for the PR. However, as it is, it bundles many changes into one for no good reason. I will update table to support Node.js v10 in the near future.