Style does not get inlined

Haroenv commented 7 years ago

for the site https://yarnpkg.com/en/package/vue-instantsearch, inlineStyles and extractStyles don't have an effect on the page:

vue-instantsearch master ✗ ➜ usus render --url https://yarnpkg.com/en/package/vue-instantsearch > vue-instantsearch.html
  ChromeLauncher Waiting for browser. +0ms
  ChromeLauncher Waiting for browser... +1ms
  ChromeLauncher Waiting for browser..... +509ms
  ChromeLauncher Waiting for browser.....✓ +3ms
  ChromeLauncher Killing all Chrome Instances +7s
vue-instantsearch master ✗ ➜ code .
vue-instantsearch master ✗ ➜ usus render --url https://yarnpkg.com/en/package/vue-instantsearch --inlineStyles true> vue-instantsearch.html
  ChromeLauncher Waiting for browser. +0ms
  ChromeLauncher Waiting for browser... +1ms
  ChromeLauncher Waiting for browser..... +512ms
  ChromeLauncher Waiting for browser.....✓ +2ms
  ChromeLauncher Killing all Chrome Instances +9s
vue-instantsearch master ✗ ➜ usus render --url https://yarnpkg.com/en/package/vue-instantsearch --extractStyles true> vue-instantsearch.html
  ChromeLauncher Waiting for browser. +0ms
  ChromeLauncher Waiting for browser... +1ms
  ChromeLauncher Waiting for browser..... +507ms
  ChromeLauncher Waiting for browser.....✓ +2ms
  ChromeLauncher Killing all Chrome Instances +8s
vue-instantsearch master ✗ ➜ usus render --url https://yarnpkg.com/en/package/vue-instantsearch --extractStyles=true> ~/Desktop/vue-instantsearch.html
  ChromeLauncher Waiting for browser. +0ms
  ChromeLauncher Waiting for browser... +1ms
  ChromeLauncher Waiting for browser..... +513ms
  ChromeLauncher Waiting for browser.....✓ +2ms
  ChromeLauncher Killing all Chrome Instances +12s
vue-instantsearch master ✗ ➜ usus render --url https://yarnpkg.com/en/package/vue-instantsearch --inlineStyles=true> ~/Desktop/vue-instantsearch.html
  ChromeLauncher Waiting for browser. +0ms
  ChromeLauncher Waiting for browser... +1ms
  ChromeLauncher Waiting for browser..... +510ms
  ChromeLauncher Waiting for browser.....✓ +3ms
  ChromeLauncher Killing all Chrome Instances +11s

Gist of the output here and live on rawgit

gajus commented 7 years ago

Are you sure it is not the --inlineStyles=true>?, i.e. true> being interpreted as non-true.

Haroenv commented 7 years ago

I tried with and without the equals sign, did I misspell something?

gajus commented 7 years ago

I meant, there should be a space after true.

But I have tried:

usus render --url https://yarnpkg.com/en/package/vue-instantsearch --inlineStyles true > vue-instantsearch.html

And it did not work. Looking into it now.

gajus commented 7 years ago

@Haroenv Fixed.

Haroenv commented 7 years ago

Amazing work!

gajus / usus

Style does not get inlined #13