search

gajus / xhprof.io

GUI to analyze the profiling data collected using XHProf – A Hierarchical Profiler for PHP.
http://xhprof.io/
Other
429 stars 103 forks source link

use html entiy for micro, to prevent encoding issues. closes #33. #37

Closed staabm closed 11 years ago

gajus commented 11 years ago

This should be solved by fixing the encoding.

staabm commented 11 years ago

thats right, but since some of my legacy projects are not yet utf-8 based I have to reconfigure things.. this simple fix on the other hand does the trick without the need for adjusting anything.

staabm commented 11 years ago

@gajus No chance to get this minor fix in? As you can see i am not the only one having this issue, see https://github.com/gajus/xhprof.io/issues/33

felixcarmona commented 10 years ago

why not solve this? :/, changing the encoding, CAN solve this, but why not use ever the html entiy? then should work on all environments........

gajus commented 10 years ago

@felixcarmona What is the environment factor thats causing this not to work in your case? @staabm said "my legacy projects are not yet utf-8 based", which didn't make sense – xhprof.io is independent of your project language/encoding.

To the point, xhprof.io is being rewritten at the moment. I have been patching things for the last few months ever so often when I have time. I should expect to get the next version out by 2014.

felixcarmona commented 10 years ago

the encoding of any php can break the micro sign, why not use the html entiy, this should work on any php environment

staabm commented 10 years ago

"my legacy projects are not yet utf-8 based", which didn't make sense – xhprof.io is independent of your project language/encoding

on our servers the encoding is defined in the server config and therefore also xhprof.io is served on non-utf8 encoding.

staabm commented 10 years ago

@felixcarmona feel free to use my fork which includes this fix and some more goodies https://github.com/staabm/xhprof.io

felixcarmona commented 10 years ago

and if anyone wants use another encoding? if the &micro ; should work on any encoding, then i don't know why you prefer use the sign in the php code an not the html &micro ;

felixcarmona commented 10 years ago

thanks @staabm !