search

gajus / xhprof.io

GUI to analyze the profiling data collected using XHProf – A Hierarchical Profiler for PHP.
http://xhprof.io/
Other
429 stars 103 forks source link

Follow redirects #72

Closed jpedro-barbosa closed 9 years ago

jpedro-barbosa commented 9 years ago

Because:

$ curl -i https://raw.github.com/gajus/xhprof.io/master/version.json
HTTP/1.1 200 Connection established

HTTP/1.1 301 Moved Permanently
Location: https://raw.githubusercontent.com/gajus/xhprof.io/master/version.json
Content-Length: 0
Accept-Ranges: bytes
Date: Wed, 17 Jun 2015 18:08:30 GMT
Via: 1.1 varnish
Age: 0
Connection: keep-alive
X-Served-By: cache-lhr6335-LHR
X-Cache: MISS
X-Cache-Hits: 0
Vary: Accept-Encoding
staabm commented 9 years ago

You should change the url instead of following the redirect

jpedro-barbosa commented 9 years ago

Why? What if github changes the url again?

staabm commented 9 years ago

Then we change again ;). For security reason we should not blindly follow redirects

jpedro-barbosa commented 9 years ago

Replaced by https://github.com/gajus/xhprof.io/pull/73. Closing.