gakimball / responsive-modular-scale

A responsive add-on to the Sass team's modular-scale gem.
http://gakimball.github.io/responsive-modular-scale/
MIT License
39 stars 4 forks source link

Fix rms-set-scales function to make it work with sass 3.4 #2

Closed karlwnw closed 9 years ago

karlwnw commented 9 years ago

Quoting sass backwards incompatibilty change in 3.4.0: "All variable assignments not at the top level of the document are now local by default. If there’s a global variable with the same name, it won’t be overwritten unless the !global flag is used. For example, $var: value !global will assign to $var globally. This behavior can be detected using feature-exists(global-variable-shadowing)."

@see http://sass-lang.com/documentation/file.SASS_CHANGELOG.html @see http://stackoverflow.com/q/27706643/1026660

gakimball commented 9 years ago

Thanks for the PR :) Could you also update the Gem dependencies to specify Sass 3.4+ and Compass 1.0+?

karlwnw commented 9 years ago

Sure ! Done, I updated the versions.

gakimball commented 9 years ago

Awesome, thank you!