Closed wumaolinmaoan closed 5 months ago
The recent updates span across multiple files, primarily focusing on importing and restructuring code for better clarity and functionality. Key changes include correcting spine data properties, reordering import statements for better readability, and enhancing texture loading logic in a Spine loader module. These modifications improve code maintainability and compatibility with older formats.
Files | Change Summary |
---|---|
.../effects-core/src/fallback/migration.ts |
Corrected images property in spine data, iterated through json.spines , mapped textureId from json.textures , and updated spine.images[i] . Declared itemGuidMap of type Record<string, string> . |
.../effects-webgl/src/gl-material.ts |
Reordered and grouped imported types and functions from @galacean/effects-core . No functional changes. |
.../effects/src/player.ts |
Reordered and restructured import statements for various types from @galacean/effects-core , adjusting formatting and grouping. |
.../spine/src/spine-loader.ts |
Modified logic for loading textures in a Spine loader module, handling different types of texture data, and added compatibility for older JSON formats. |
🐰 In code's vast and endless sea,
We shuffled imports with glee.
Textures now load, old and new,
Spine data shines, fresh and true.
Organized, neat, and clear,
Our code sings, loud and dear.
🖥️✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Bug Fixes
images
property in spine data to ensure accurate texture mapping.Refactor
Compatibility