coderabbitai[bot]
commented
4 months ago Walkthrough
The updates primarily enhance the effects-core package by upgrading dependencies, refining class constructors, and improving method signatures to incorporate the PlayableGraph component. Key changes involve removing TypeScript error suppression comments, refining the handling of animations, and adding new methods and properties to improve the functionality of playables and their graphs. Additionally, similar updates are applied to several plugins to ensure compatibility with the new PlayableGraph structure.
Changes
| Files/Paths | Change Summary |
|---|---|
packages/effects-core/package.json |
Updated dependency @galacean/effects-specification from 2.0.0-alpha.12 to 2.0.0-alpha.14. |
.../src/comp-vfx-item.ts |
Added import for PlayableGraph and modified visibility and initialization of several properties. |
.../src/engine.ts |
Removed //@ts-expect-error comments related to jsonScene.animations. |
.../src/fallback/migration.ts |
Added animations array to jsonScene and removed unnecessary ts-expect-error comments. |
.../src/plugins/cal/animation-playable.ts |
Constructor of AnimationPlayable now accepts a PlayableGraph parameter. |
.../src/plugins/cal/calculate-vfx-item.ts |
Added import for PlayableGraph and modified createPlayable methods to accept PlayableGraph parameter. |
.../src/plugins/cal/playable-graph.ts |
Added addPlayable method, introduced new properties, and enhanced several methods in PlayableGraph and Playable classes. |
.../src/plugins/cal/timeline-asset.ts |
Modified createPlayable method to accept PlayableGraph parameter and updated method implementations accordingly. |
.../src/plugins/cal/track.ts |
Modified method signatures and implementations to include PlayableGraph parameter. |
.../src/plugins/particle/particle-vfx-item.ts |
Added import for PlayableGraph and modified createPlayable method to accept PlayableGraph parameter. |
.../src/plugins/sprite/sprite-item.ts |
Modified createPlayable method in SpriteColorPlayableAsset to accept PlayableGraph parameter. |
plugin-packages/model/src/gltf/loader-ecs.ts |
Added animations array to the object being returned in LoaderECSImpl class. |
plugin-packages/model/src/plugin/model-item.ts |
Added //@ts-expect-error comment before calling clipObj.fromData(clipData) in ModelAnimationComponent class. |
In code's embrace, the graphs now play, With animations bright as day. Errors cleared, the paths refined, New methods, properties aligned. From sprites to particles, all in sync, A symphony of changes, in code's ink. The rabbit hops, with joy it sings, For in this update, magic springs.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Release Notes
Dependency Updates
@galacean/effects-specificationto version2.0.0-alpha.14.New Features
PlayableGraphintegration for enhanced animation and effects handling.PlayableGraphandPlayableclasses for improved frame preparation and time management.Bug Fixes
ts-expect-errorcomments for cleaner code and better type checking.animationsarray to various scene objects to ensure proper handling of animations.Enhancements
createPlayablemethods across multiple classes to acceptPlayableGraphparameters for more flexible and powerful animations.PlayableGraphwhere necessary.These updates enhance the overall functionality and performance of the animation and effects systems, providing a more robust and flexible framework for end-users.