search

galacean / effects-runtime

It can load and render cool animation effects
https://galacean.antgroup.com/effects/
MIT License
324 stars 8 forks source link

feat: 移除 Player 初始化参数 gl，不再支持 #376

Closed yiiqii closed 4 months ago

yiiqii commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

Walkthrough

Recent updates across multiple packages focus on enhancing code maintainability, improving type safety, and refining functionality. Key changes include ESLint rule adjustments, version upgrades for TypeScript-related packages, refactoring of texture generation, and updates to WebGL context handling. Additionally, asynchronous methods were streamlined, and various imports and type definitions were reorganized to optimize performance and clarity.

Changes

Files/Paths Change Summaries
.eslintrc.js, package.json Adjusted ESLint rules and updated TypeScript ESLint plugin versions.
packages/effects-core/src/engine.ts, packages/effects-core/src/render/render-frame.ts Refactored texture generation and updated method signatures.
packages/effects-core/src/material/material-data-block.ts Updated type check in isUniformStruct function.
packages/effects-core/src/plugins/interact/event-system.ts, web-packages/demo/src/common/three-display-object.ts Removed and reorganized imports, updated references to InteractBehavior.
packages/effects-core/src/render/framebuffer.ts Renamed parameter in dispose method.
packages/effects-core/src/render/renderer.ts Added setFramebuffer method.
packages/effects-core/src/scene.ts Removed commented-out TODOs.
packages/effects-core/src/texture/texture.ts Added sourceOptions object, refactored texture generation functions.
packages/effects-core/src/ticker.ts Changed import path for clamp, renamed private variable _deltaTime to dt.
packages/effects-threejs/src/three-display-object.ts Updated method call from createVFXItemsAsync to createVFXItems.
packages/effects-webgl/src/gl-renderer.ts Fixed comment, modified return types in getFramebuffer and getTemporaryRT methods.
packages/effects/src/index.ts Updated Renderer.create function signature.
packages/effects/src/player.ts Removed gl property from PlayerConfig, refactored initialization logic.
plugin-packages/model/demo/src/utility.ts Updated type of callback parameter in createSlider function.
plugin-packages/model/package.json Updated @vvfx/resource-detection dependency version.
plugin-packages/model/src/gltf/loader-ecs.ts Added line to push mesh.geometryData into this.geometries array.
web-packages/demo/src/single.ts Updated URL for json variable and used it in player.loadScene() method.

In code's realm, where changes flow, Textures gleam, and functions grow. ESLint rules now finely tuned, Type checks hum a clearer tune. Async calls now swift and bright, WebGL glows in the night. CodeRabbit hops with glee, For code is clean as it can be. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to full the review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.