search

galacean / effects-runtime

It can load and render cool animation effects
https://galacean.antgroup.com/effects/
MIT License
324 stars 8 forks source link

perf: opt playable lifetime func #379

Closed wumaolinmaoan closed 4 months ago

wumaolinmaoan commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate limit exceeded

@yiiqii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 49 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 5d66898535ad2de155de508fda2aa7d016748d00 and b893a46fe7db9bfff68438703830c8b22417cb11.

Walkthrough

The changes across various files in the project primarily involve refactoring and enhancements. Key updates include the introduction of FrameContext for better context management, renaming bindingItem to binding, and adding new methods and properties to several classes. Additionally, there are updates in import paths, restructuring of export statements, and modifications to test files to align with the new structure. Two new track classes, ActivationTrack and SpriteColorTrack, were introduced, enhancing the timeline functionality.

Changes

Files/Paths Change Summary
.../effects-core/src/plugins/cal/calculate-vfx-item.ts, .../effects-core/src/plugins/cal/calculate-item.ts Added FrameContext, modified data visibility, added binding property, and updated methods to use binding.
.../effects-core/src/plugins/cal/playable-graph.ts Introduced FrameContext, added new methods to PlayableGraph and Playable classes, updated existing methods to use FrameContext, and added new fields.
.../effects-core/src/plugins/cal/timeline-asset.ts Updated method signatures to use FrameContext, refactored prepareFrame and evaluate methods, and added new private methods for handling subtracks.
.../effects-core/src/plugins/particle/particle-vfx-item.ts, .../effects-core/src/plugins/sprite/sprite-item.ts Added FrameContext and VFXItem imports, updated method signatures to use context: FrameContext, and refactored methods to use binding.
.../effects-core/src/plugins/timeline/tracks/activation-track.ts Introduced ActivationTrack class with createTrackMixer method.
.../effects-core/src/plugins/timeline/tracks/sprite-color-track.ts Introduced SpriteColorTrack class for sprite color manipulation within the timeline.
.../effects-core/src/fallback/migration.ts Renamed dataType values and variable objectBindingTrackData to bindingTrackData in convertTimelineAsset function.
.../web-packages/test/case/2d/src/inspire/scene-list.ts Commented out properties of the butterfly object.
.../web-packages/test/unit/src/effects-core/plugins/sprite/sprite-base.spec.ts Replaced objectBindingTracks with masterTracks and introduced spriteBindingTrack variable.
.../effects-core/src/plugins/index.ts Updated export statements to export tracks related to the timeline instead of the previous cal/track.
.../effects-core/src/comp-vfx-item.ts Added TrackAsset import, replaced bindingItem with binding, refactored initializeTrackBindings method, and invoked this.timelinePlayable.play().
.../effects-core/src/plugins/timeline/track.ts Adjusted imports, renamed bindingItem to binding, added trackType property, and introduced new methods and enum in TrackAsset.
.../effects-core/src/vfx-item.ts Modified getComponent method to return a value of type T directly.
.../plugin-packages/editor-gizmo/demo/src/gizmo-3d.ts, .../plugin-packages/editor-gizmo/demo/src/gizmo-wireframe.ts, .../plugin-packages/editor-gizmo/demo/src/gizmo.ts, .../plugin-packages/editor-gizmo/demo/src/scene.ts Updated import statements for GizmoComponent to use package path.
.../plugin-packages/editor-gizmo/src/index.ts Added export statement for GizmoComponent.
.../plugin-packages/model/package.json Updated @vvfx/resource-detection dependency version from "0.6.0-alpha.5" to "0.6.0-alpha.7".

Poem

In the realm of code, where changes bloom,
FrameContext whispers in the room.
Bindings now align, old names retire,
Tracks and sprites with colors inspire.
Gizmos dance with paths anew,
A rabbit's joy, for updates true.
🐇✨ Code evolves, like morning dew.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.