search

galacean / effects-runtime

It can load and render cool animation effects
https://galacean.antgroup.com/effects/
MIT License
324 stars 8 forks source link

fix: support morph animation #387

Closed liuxi150 closed 4 months ago

liuxi150 commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Rate limit exceeded

@yiiqii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 53 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 261b0a01a4fc0400cce1c19b7a8bed97739decec and cf193f8c4b58ab8fba71fd3b5f2d56b38e535c5c.

Walkthrough

The recent updates encompass various enhancements and fixes across multiple packages, including effects-core, effects-webgl, and several within the model plugin. Key changes include the addition of a method to calculate maximum time in the BezierCurve class, updates to WebGL geometry handling, revised URLs for resources, version adjustments, and significant improvements to animation and mesh handling in the model package.

Changes

File Path Change Summary
packages/effects-core/src/math/value-getter.ts Added getMaxTime() method to BezierCurve class to calculate and return the maximum time value based on curveMap.
packages/effects-webgl/src/gl-geometry.ts Modified condition in GLGeometry class method to check for indexOffset and indexFormat.
plugin-packages/model/demo/src/json.ts Updated URLs for images and models, adding new ones and commenting out some existing ones.
plugin-packages/model/package.json Updated package version from 1.4.5 to 1.4.4 and dependency on @vvfx/resource-detection from 0.6.0-alpha.6 to 0.6.0-alpha.7.
plugin-packages/model/src/gltf/json-converter.ts Removed unused imports, enhanced handling of material properties, and improved processing of animation tracks and mesh options for morphing.
plugin-packages/model/src/gltf/loader-ecs.ts Modified imported types, added animations array, adjusted mesh component data handling, and updated component data processing in LoaderECSImpl class.
plugin-packages/model/src/plugin/model-item.ts Added morphWeights property to ModelMeshComponent, modified setTransform in ModelCameraComponent, and enhanced AnimationComponent and ModelAnimationClip classes.
plugin-packages/model/src/runtime/animation.ts Updated PMorph class to require morphWeightsArray, removed dispose method, and added updateWeights method.
plugin-packages/model/src/runtime/mesh.ts Enhanced morph weights handling in PMesh and PSubMesh classes, and simplified morph object creation in EffectsMeshProxy class.

Sequence Diagram(s) (Beta)

No sequence diagrams generated as the changes are too varied and specific.

Poem

In the code where changes bloom,
Curves now find their max time soon,
WebGL checks with careful sight,
URLs updated, shining bright.
Morph weights dance in mesh's heart,
Animations given a brand new start.
Version bumps and types refined,
A coder's dream, so well aligned. 🌟🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.