search

galacean / effects-runtime

It can load and render cool animation effects
https://galacean.antgroup.com/effects/
MIT License
324 stars 8 forks source link

perf: opt activation track logic #401

Closed wumaolinmaoan closed 4 months ago

wumaolinmaoan commented 4 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 4 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The latest update introduces a new BinaryAsset class for handling binary data, refines the rendering process in the Composition class, and adjusts the import order in the Engine class. It also enhances the PlayableGraph, TimelinePlayable, and ParticleBehaviourPlayable classes with improved state handling and processing logic. Additionally, it updates the TrackAsset, TimelineClip, and RuntimeClip classes for better clip management and serialization helper functions to support ArrayBuffer.

Changes

File Path Change Summary
packages/effects-core/src/binary-asset.ts Introduced BinaryAsset class for handling binary data, extending EffectsObject with a buffer property and a fromData method for deserialization.
packages/effects-core/src/composition.ts Refactored gatherRendererComponent method in Composition class for improved recursive traversal and rendering of VFXItem children.
packages/effects-core/src/engine.ts Swapped import order of generateWhiteTexture and generateTransparentTexture, and added code to handle jsonScene.bins data in the Engine class.
packages/effects-core/src/index.ts Added export statement for 'binary-asset' module.
packages/effects-core/src/plugins/cal/playable-graph.ts Enhanced PlayableGraph and Playable classes with output node state initialization, improved play and pause methods, and updated frame processing methods.
packages/effects-core/src/plugins/cal/timeline-asset.ts Simplified evaluate method in TimelinePlayable class, removed commented-out code in createPlayableGraph, and made sortTracks method private.
packages/effects-core/src/plugins/particle/particle-vfx-item.ts Added a conditional check before calling this.start(context) in processFrame method of ParticleBehaviourPlayable class.
packages/effects-core/src/plugins/timeline/track.ts Updated TrackAsset, TimelineClip, and RuntimeClip classes for better clip management, including changes to enable setter logic, renaming bindingItem to boundItem, and updating clip end behavior.
packages/effects-core/src/serialization-helper.ts Updated SerializationHelper class to include ArrayBuffer in checkDataArray method.
web-packages/test/unit/src/effects-core/plugins/sprite/sprite-base.spec.ts Replaced references to track.bindingItem with track.boundItem in sprite-base.spec.ts test file.

Poem

In the code where magic flows,
A BinaryAsset now bestows,
Playable graphs with states anew,
Rendering paths more clear and true.
Clips now dance and frames align,
Serialization checks refine.
Oh, the joy in each commit,
A rabbit's heart, forever lit! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.