Closed wumaolinmaoan closed 4 months ago
The recent update to the @galacean/effects-core
package mainly focuses on transitioning from spec.Composition
to spec.CompositionData
for various methods and classes. This change affects the AssetManager
, CompositionSourceManager
, and other related components. Additionally, some imports were adjusted, and redundant properties were removed to streamline the codebase and improve type consistency across the package.
Files/Paths | Change Summary |
---|---|
packages/effects-core/package.json |
Updated dependency on @galacean/effects-specification from version "2.0.0-alpha.16" to "2.0.0-alpha.17". |
.../src/asset-manager.ts , .../src/composition-source-manager.ts |
Changed parameter types from spec.Composition to spec.CompositionData in several methods and properties. |
.../src/comp-vfx-item.ts |
Updated type import from TimelinePlayable to Playable and modified sceneBindings array type. |
.../src/composition.ts |
Changed import type for CompositionSourceManager , removed transform property, and adjusted constructor. |
.../src/fallback/migration.ts , .../src/plugin-system.ts |
Updated methods to accept CompositionData instead of Composition . |
.../src/plugins/cal/timeline-asset.ts |
Removed graph property and related assignments in TimelineAsset class. |
.../src/three-composition.ts , .../src/three-display-object.ts , .../src/player.ts |
Removed CompositionSourceManager instantiation and adjusted related logic. |
plugin-packages/model/src/gltf/json-converter.ts |
Removed @ts-expect-error comment. |
plugin-packages/model/src/gltf/loader-ecs.ts |
Updated composition type to CompositionData and added new properties to the default composition object. |
web-packages/test/unit/src/effects-core/assert-manager.spec.ts |
Simplified texture access within comp object. |
web-packages/test/unit/src/effects-core/fallback/null/end-behavior.spec.ts |
Added new variable items and updated assertion logic. |
In the land of code so bright,
Compositions took a flight,
From old to new, they changed their name,
CompositionData
rose to fame.
With imports fixed and types aligned,
The code now runs so smooth, refined.
Hooray for changes, small and grand,
In our digital wonderland! 🌟🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Dependencies
@galacean/effects-specification
dependency from version2.0.0-alpha.16
to2.0.0-alpha.17
.Refactor
spec.Composition
withspec.CompositionData
across various methods and functions for improved data handling.CompositionSourceManager
in multiple classes.Tests
endBehavior
property more effectively.Bug Fixes
@ts-expect-error
comment inJSONConverter
class, indicating improved error handling or type assertions.