Closed wumaolinmaoan closed 4 months ago
[!WARNING]
Review failed
The pull request is closed.
The recent changes primarily focus on refining the SpriteComponent
and VFXItem
classes. Specifically, the SpriteComponent
class's start()
method no longer sets priority
based on listIndex
, while the VFXItem
class now uses renderOrder
instead of listIndex
. Additionally, imports in vfx-item.ts
have been reordered for clarity.
Files | Summary |
---|---|
packages/effects-core/src/plugins/sprite/sprite-item.ts |
Removed setting this.priority to this.item.listIndex in SpriteComponent class's start() method. |
packages/effects-core/src/vfx-item.ts |
Reordered imports, deprecated listIndex in favor of renderOrder , and adjusted type imports related to SpriteComponent . |
In the code where sprites do dance,
A change was made, not by chance.
Priorities no longer tied,
To list indexes, they now glide.
Render orders take the stage,
In this bright, new coding age.
🎨✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
listIndex
in favor ofrenderOrder
for more intuitive naming.