Closed yiiqii closed 2 months ago
[!WARNING]
Rate limit exceeded
@yiiqii has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 6 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 7bca466d3c088bab35af28969727ec2a7a6781e7 and da6c4c9f6629f3c21a2648e9b70c1d557e276ca4.
The changes primarily involve updating several shader files and JavaScript modules within the codebase to improve functionality and maintain consistency. This includes modifying shader macro declarations, replacing #pragma
with #include
directives for GLSL imports, and refining alpha calculations. Additionally, type declarations and parameters have been updated across these files to ensure better type handling and clarity in shader-related operations.
Files | Change Summaries |
---|---|
packages/…/interact/interact-mesh.ts , plugin-…/spine-mesh.ts |
Revised shader macro declarations, adding ShaderMarcos type. |
packages/…/particle/particle-mesh.ts |
Adjusted ParticleMesh and shader functions to refine RENDER_MODE macro handling, removed PRE_MULTIPLY_ALPHA macro. |
packages/…/particle/particle-system.ts |
Introduced new ParticleContent type. |
packages/…/blend.glsl , item.frag.glsl |
Refactored alpha value calculations in blendColor functions. |
packages/…/item-frame.frag.glsl , particle.vert.glsl , trail.vert.glsl , value.glsl |
Replaced #pragma directives with #include for GLSL file imports. |
plugin-…/wireframe.ts |
Modified createGizmoShader function to accept an additional level parameter. |
plugin-…/standard-shader-source.ts |
Updated WebGL version detection logic in getSourceCode function using a more explicit if-else block. |
scripts/rollup-plugin-glsl-inner.js |
Renamed assemblePragmaContent to assembleIncludeContent and updated the keyword parameter default value in processContent function from 'pragma' to 'include' . |
In code of light and shader blend,
Marcos now their type ascend.
Particles dance with render's might,
Gone are the alphas, pure delight.
Includes now hark, where pragmas tread,
Gizmos level up instead.
🎨✨🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Refactor
#pragma
and#import
directives with#include
.PRE_MULTIPLY_ALPHA
andRENDER_MODE
).New Features
createGizmoShader
function to accept an additionallevel
parameter.Bug Fixes