Closed Sruimeng closed 3 months ago
The recent changes to the spine
plugin package focus on updating matrix uniform names across shaders and related classes. Specifically, the uniform previously declared as uModel
has been renamed to effects_ObjectToWorld
. This rename aligns the shader code (vertex.glsl
), rendering logic (slot-group.ts
), and material settings (spine-mesh.ts
) with a more descriptive and possibly standardized naming convention.
File Path | Change Summary |
---|---|
plugin-packages/.../vertex.glsl |
Updated uniform declaration from uModel to effects_ObjectToWorld in vertex.glsl |
plugin-packages/.../slot-group.ts |
Simplified draw method in SlotGroup class by changing how mesh.render(renderer) is called |
plugin-packages/.../spine-mesh.ts |
Renamed matrix key in material.setMatrix from uModel to effects_ObjectToWorld |
sequenceDiagram
participant User
participant Renderer
participant SlotGroup
participant SpineMesh
User->>Renderer: Initiate rendering
Renderer->>SlotGroup: Call draw method
SlotGroup->>SpineMesh: Call mesh.render(renderer)
SpineMesh->> Renderer: Set matrix with effects_ObjectToWorld
Renderer->>User: Render final output
Amidst the code in shaders bright,
A change was made to bring delight.
No moreuModel
in the air,
Welcomeeffects_ObjectToWorld
with flair.
Simplify and render clean,
Spine's new update, a perfect sheen.
🌟✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
Refactor
Bug Fixes