Closed liuxi150 closed 3 weeks ago
The recent updates introduce additional parameters and options to scene handling functions in the camera module, refine versioning in the GLTF scene loader, adjust the world matrix of meshes before rendering, upgrade mesh priority assignment logic to ensure uniqueness, and modify camera property checks within unit tests. These changes enhance overall functionality, ensure more dynamic and flexible scene management, and improve test accuracy.
Files | Change Summary |
---|---|
plugin-packages/model/demo/src/camera.ts |
Added parameters to getCurrentScene and updated loadScene to include loadOptions with pluginData . |
plugin-packages/model/src/gltf/loader-ext.ts |
Updated version in loadGLTFScene function from '2.1' to '0.8.9-beta.9'. |
plugin-packages/model/src/runtime/mesh.ts |
Set worldMatrix of prim.effectsMesh before adding it to renderObjectSet in PMesh class. |
plugin-packages/model/src/runtime/scene.ts |
Improved mesh priority assignment in PSceneManager to ensure unique values. |
plugin-packages/model/test/src/plugin-unit.spec.ts |
Updated updateDefaultCamera function call and corresponding assertions in the test suite. |
sequenceDiagram
participant User
participant CameraModule
participant RenderModule
participant SceneLoader
participant TestSuite
User->>CameraModule: getCurrentScene()
CameraModule->>SceneLoader: loadScene with loadOptions
SceneLoader->>RenderModule: Apply new scene parameters (skyboxType etc.)
TestSuite->>CameraModule: updateDefaultCamera
TestSuite->>RenderModule: Assert camera properties
Note over CameraModule,RenderModule: Improved mesh priority and `worldMatrix`.
In bytes and lines, we dance today,
Scenes load with the skybox's sway.
Meshes align, priorities climb,
Rendering flows like perfect rhyme.
Camera tests with aspect clear,
A coder's joy, updates we cheer! 🚀
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Improvements
0.8.9-beta.9
.Bug Fixes
Testing