Closed wumaolinmaoan closed 3 months ago
The changes enhance the Material
class with a new enabledMacros
property, impacting how macros are handled across related classes. Key updates include replacing the macros
property with enabledMacros
in GLMaterial
, integrating JSONConverter
for scene processing in gizmo
demos, and updating GizmoComponent
and wireframe
functionalities to work with the new data structures and materials.
File Path | Change Summary |
---|---|
packages/effects-core/src/material/material.ts |
Added the enabledMacros property to the Material class. |
packages/effects-webgl/src/gl-material.ts |
Replaced the macros property with enabledMacros and updated related methods and shader initialization. |
plugin-packages/editor-gizmo/demo/src/gizmo-3d.ts |
Added JSONConverter to process the scene before loading it into the player. |
plugin-packages/editor-gizmo/demo/src/gizmo-wireframe.ts |
Imported JSONConverter and used it to process the test_scene JSON data before loading it into the player . |
plugin-packages/editor-gizmo/src/gizmo-component.ts |
Updated imports, modified createModelContent method to work with new data structures, and adjusted mesh creation using createModeWireframe . |
plugin-packages/editor-gizmo/src/wireframe.ts |
Modified updateWireframeMesh and createModeWireframe functions to include additional parameters and updated logic for handling material properties. |
🌟 In code's embrace, new macros rise,
WebGL’s shaders see through fresh eyes.
Gizmos dance with JSON flair,
Meshes align in structured air.
A rabbit's heart, full of cheer,
For these updates, we now revere. 🐇✨
[!TIP]
You can customize the tone of the comments in your PRs
Specify the tone of the comments in your PRs by configuring the `tone-instructions` setting in your project's settings in CodeRabbit.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
JSONConverter
.Refactor
macros
withenabledMacros
for better shader initialization and macro handling.createModelContent
to align with new data structures in 3D gizmo components.