search

galacean / effects-runtime

It can load and render cool animation effects
https://galacean.antgroup.com/effects/
MIT License
324 stars 8 forks source link

feat: add postprocess volume #510

Closed wumaolinmaoan closed 3 months ago

wumaolinmaoan commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates to the effects-core package involve significant enhancements to the handling and processing of post-processing effects, particularly removing the globalVolume logic and replacing it with a new class, PostProcessVolume. The changes streamline post-processing settings, include new exports, and adjust JSON configurations. Additionally, several TypeScript-related adjustments and error suppressions were made to ensure seamless integration.

Changes

Files/Paths Change Summary
packages/effects-core/src/asset-manager.ts Removed globalVolume logic in compositions. Simplified JSON data processing.
packages/effects-core/src/components/index.ts Corrected export of effect-component and added export for post-process-volume.
packages/effects-core/src/components/post-process-volume.ts Introduced new PostProcessVolume class with properties for various post-processing effects.
packages/effects-core/src/composition-source-manager.ts Removed handling for globalVolume in ContentOptions and getContent method.
packages/effects-core/src/composition.ts Changed GlobalVolume to PostProcessVolumeData. Added a globalVolume property in Composition.
packages/effects-core/src/effects-package.ts Added normalize and indexCount properties to vertexChannel and subMesh objects respectively.
packages/effects-core/src/render/global-volume.ts Renamed GlobalVolume to PostProcessVolumeData. Updated property types and removed usePostProcessing.
packages/effects-core/src/render/post-process-pass.ts Modified ToneMappingPass class to cast boolean values to integers for shader uniform setting.
packages/effects-core/src/render/render-frame.ts Changed imports and types from GlobalVolume to PostProcessVolumeData. Updated RenderFrame initialization and usage.
plugin-packages/model/demo/ibl.json Removed "usePostProcessing" attribute under "globalVolume".
plugin-packages/model/demo/trail-demo.scene.json Removed "usePostProcessing" attribute under "globalVolume".
web-packages/demo/src/post-processing.ts Updated imports. Added PostProcessVolume component to composition. Removed hackGlobalVolume function and related code.
web-packages/devtools/src/assets/scenes/trail-demo.scene.json Removed "usePostProcessing" attribute under "globalVolume".
web-packages/test/unit/src/effects-core/composition/composition.spec.ts Removed usePostProcessing property under globalVolume in tests.
web-packages/test/unit/src/effects-core/plugins/sprite/sprite-item.spec.ts Removed usePostProcessing property under globalVolume in multiple test sections. Removed or commented-out lines setting properties under globalVolume.
plugin-packages/model/src/gltf/loader-impl.ts Added // @ts-expect-error comment to suppress TypeScript errors when pushing items from gltfResource.scenes[0].vfxItemData into this.items.

Poem

In the realm of code, where logic twines,
We cast out shadows, new stars align.
Post-processing blooms, a vivid dance,
HDR and Tone, in a single glance.
Goodbye old volumes, hello new light,
Our scenes now shimmer, in digital night.
🎨✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.