Finalize NFT Marketplace

galacticcouncil / Basilisk-node

Basilisk - cross-chain liquidity protocol on Kusama

Apache License 2.0

67 stars 19 forks source link

Finalize NFT Marketplace #436

Open green-jay opened 2 years ago

green-jay commented 2 years ago

Legacy PRs: https://github.com/galacticcouncil/Basilisk-node/pull/137 (merged for testing purposes)

[x] Add more tests (e.g. do_buy function with mutation checks, other scenarios)
[x] Address any other pending comments in legacy PRs
[ ] Do full review of pallet-marketplace (ideally multiple peers)
[ ] Rebenchmark on reference machine
[ ] Remove Marketplace call filter in basilisk runtime

dmoka commented 1 year ago

I am going to pick this up as discussed with @lumir-mrkva that we want to utilize auctions soon on Basilisk.

green-jay commented 1 year ago

I am going to pick this up as discussed with @lumir-mrkva that we want to utilize auctions soon on Basilisk.

The status quo of the marketplace chaged since April. So the list should include additionally:

[x] migrate to the latest version of pallet-nft
[ ] refactor the marketplace to support multiple currencies

dmoka commented 1 year ago

@green-jay , as for pallet-nft, I just updated to the latest version and everything is still functional, so no breaking changes. I guess it is fine, or did you expect some actual code changes in the marketplace pallet (because of some important behavioral change in the pallet-nft)?

green-jay commented 1 year ago

@green-jay , as for pallet-nft, I just updated to the latest version and everything is still functional, so no breaking changes. I guess it is fine, or did you expect some actual code changes in the marketplace pallet (because of some important behavioral change in the pallet-nft)?

as long as it works with latest changes should be fine

enthusiastmartin commented 1 year ago

Completed?

dmoka commented 1 year ago

Completed?

Nope, we froze the work regarding this, as it had low priority. Some work has been done on branch feat/finalize-nft-marketplace, but not complete.

We are planning to add multicurrency support which would require some work. The plan would be to extend the nft marketplace functionality without breaking the existing APIs.