search

galacticcouncil / Basilisk-ui-old

26 stars 10 forks source link

Add talisman identicon to accounts from talisman #955

Open jak-pan opened 2 years ago

jak-pan commented 2 years ago

We're showing identicons for selected accounts in various places in the UI. We should show talisman representation of this in our UIs when talisman wallet account is selected.

SwamiTLSM commented 2 years ago

We're showing identicons for selected accounts in various places in the UI. We should show talisman representation of this in our UIs when talisman wallet account is selected.

Since the user selected option is internal to the extension (and not available to the dapp), if the dapp implements Talisman Orbs there may be a discrepancy between what the extension shows and what the dapp shows, depending on what the user has set.

We have been toying with the option of pushing the user-preferred SVG avatar down to the dapp with the account details data, which would allow the dapp to just inject the element into the DOM instead of having to regenerate it. This may be the better option as it allows us to add more avatar options in the future.

jak-pan commented 2 years ago

We're showing identicons for selected accounts in various places in the UI. We should show talisman representation of this in our UIs when talisman wallet account is selected.

Since the user selected option is internal to the extension (and not available to the dapp), if the dapp implements Talisman Orbs there may be a discrepancy between what the extension shows and what the dapp shows, depending on what the user has set.

We have been toying with the option of pushing the user-preferred SVG avatar down to the dapp with the account details data, which would allow the dapp to just inject the element into the DOM instead of having to regenerate it. This may be the better option as it allows us to add more avatar options in the future.

I'm not sure if I understand this. We just need a way to generate this icon for account (I guess it's generated from the public key of an account) I don't see any option to change this in talisman. We're doing the same thing for polkadot.js and want to show user the same thing when they are selecting account in our app next to his account address and name like so. With the difference they would have talisman icon there instead of basilisk and secondary

image