search

galacticcouncil / bench-wizard

CLI tool to streamline Substrate benchmarking process.
Apache License 2.0
2 stars 1 forks source link

Adjust notes in benchmark output #8

Closed vgantchev closed 3 years ago

vgantchev commented 3 years ago

Per request of @jak-pan in https://github.com/galacticcouncil/HydraDX-docs/pull/36

If we want 0% or better, shall we also set DIFF_MARGIN=0? https://github.com/galacticcouncil/bench-wizard/blob/main/bench_wizard/benchmark.py#L14

cc @enthusiastmartin

jak-pan commented 3 years ago

There is 10% margin. I'd maybe be ok with going only 5% but let's keep it 10%. The wording however didn't make sense since it's better if you are more than 0 and worse if you were less than 0 not + or -10%

vgantchev commented 3 years ago

thanks guys 👍