feat: add sell_all for route executor

galacticcouncil / hydration-node

Hydration node - Cross-chain liquidity protocol built with Polkadot-SDK

https://hydration.net

Apache License 2.0

172 stars 69 forks source link

feat: add sell_all for route executor #888

Closed dmoka closed 2 months ago

dmoka commented 3 months ago

Fixes https://github.com/galacticcouncil/hydration-node/issues/883

[x] test out on chopsticks

github-actions[bot] commented 3 months ago

Crate versions that have been updated:

runtime-integration-tests: v1.23.2 -> v1.23.3
pallet-route-executor: v2.5.1 -> v2.6.0
hydradx-traits: v3.4.0 -> v3.5.0

Runtime version has not been increased.

dmoka commented 2 months ago

I assume the native balance test is also a fee payment asset and in this case LGTM

@jak-pan Although it is true that the fee payment asset is indeed HDX in the native balance test, it does not have any impact as in integration tests the tx fees are not deducted directly. Anyway, I tested out sell_all on chopsticks, and working fine, first the fee is deducated then the rest is sold in sell_all

dmoka commented 2 months ago

https://github.com/galacticcouncil/hydration-ui/pull/1042