Fix split conviction vote

gui1117 commented 1 month ago

Fix https://github.com/galacticcouncil/HydraDX-ui/issues/1480

AFAICT hydration runtime handles split conviction:

https://github.com/galacticcouncil/hydration-node/blob/769c33d63d24356791c2f0e276350ebdc2914005/pallets/staking/src/integrations/democracy.rs#L41-L54

So I implemented the same logic here.

Also I am not good at typescript so please review carefully.

I still have to test it manually, but I don't really know how to use the testnet.

Also is there integration tests?

Hydration address: 7N5ixUUAHfyynZFDfXzB9FLnAAKgynWb95jBdujCLu1e4wLc

netlify[bot] commented 1 month ago

Deploy Preview for testnet-hydra-app ready!

Name	Link
Latest commit	af1324bc5fafebe66637aabcd8e7d1a079f87c81
Latest deploy log	https://app.netlify.com/sites/testnet-hydra-app/deploys/669e92fa13424c00082fed93
Deploy Preview	https://deploy-preview-1481--testnet-hydra-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	6 paths audited Performance: 33 (🔴 down 5 from production) Accessibility: 90 (no change from production) Best Practices: 100 (no change from production) SEO: 88 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for hydradx-storybook ready!

Name	Link
Latest commit	af1324bc5fafebe66637aabcd8e7d1a079f87c81
Latest deploy log	https://app.netlify.com/sites/hydradx-storybook/deploys/669e92fafa41b700082556cf
Deploy Preview	https://deploy-preview-1481--hydradx-storybook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for edge-hydra-app ready!

Name	Link
Latest commit	af1324bc5fafebe66637aabcd8e7d1a079f87c81
Latest deploy log	https://app.netlify.com/sites/edge-hydra-app/deploys/669e92fa3b68ff0008f5d932
Deploy Preview	https://deploy-preview-1481--edge-hydra-app.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	6 paths audited Performance: 26 (no change from production) Accessibility: 90 (no change from production) Best Practices: 100 (no change from production) SEO: 88 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

gui1117 commented 1 month ago

Yes, applied, also the PR should be editable by maintainers, feel free to change it, And considering you did most of the work with testing, I don't need tip