Closed cgannonucm closed 2 months ago
The problem here is that this line in the parameter file:
<massDestructionAbsolute value="=[mergerTreeMassResolution::massResolution]" />
is referencing the massResolution
parameter inside the mergerTreeMassResolution
section. But, when you use the mergerTreeMassResolutionScaled
class that parameter doesn't exist.
So, you'll want to change how the destruction threshold is computed. This should work:
<nodeOperator value="satelliteDestructionMassThreshold">
<!-- Subhalos will be removed if they fall below the merger tree mass resolution limit. -->
<massDestructionAbsolute value="=[mergerTreeMassResolution::massResolutionMinimum]" />
<massDestructionMassTreeFraction value="=[mergerTreeMassResolution::massResolutionFractional]" />
</nodeOperator>
I opened PR #680 to provide a more helpful error message when this type of problem arises.
Thanks!
Contact Details
cgannon@ucmerced.edu
What happened?
When attempting to build trees using fractional mass resolution, ex:
parameter validation fails with the following error:
parameter [massResolution] not present and no default given
This issue can be worked around by simply adding a redundant<massResolution value="1.00" />
tag.Build information
Ideally, run
./Galacticus.exe parameters/report.xml
which will provide a detailed report and paste the output here. ##© 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021, 2022, 2023, 2024
MM: -> Begin task: report MM: This is Galacticus: revision 550ec2bb0e90ab60c75fdae7fb8962b5dc225068 (branch: master; build time: Sat Aug 24 19:50:31 UTC 2024) MM: Built with: :GSL_version[2.6]:FoX_version[4.1.0]:HDF5_version[1.8.20]:FCCOMPILER[gfortran]:PREPROCESSOR[cpp]:CCOMPILER[gcc]:CPPCOMPILER[g++]:FCFLAGS[-ffree-line-length-none -frecursive -DBUILDPATH='./work/build' -J./work/build/moduleBuild/ -I./work/build/ -fintrinsic-modules-path /usr/local/finclude -fintrinsic-modules-path /usr/local/include -fintrinsic-modules-path /usr/local/include/gfortran -fintrinsic-modules-path /usr/local/lib/gfortran/modules -L/usr/local/lib -L/usr/local/lib64 -fuse-ld=bfd -DTHREADSAFEIO -static -pthread -Wall -fbacktrace -ffpe-trap=invalid,zero,overflow -fdump-core -O3 -ffinite-math-only -fno-math-errno -fopenmp -DSTATIC -g -DPROCPS -DOFDAVAIL -DFFTW3AVAIL -DANNAVAIL -DQHULLAVAIL -DMATHEVALAVAIL]:FCFLAGS_NOOPT[-ffree-line-length-none -frecursive -DBUILDPATH='./work/build' -J./work/build/moduleBuild/ -I./work/build/ -fintrinsic-modules-path /usr/local/finclude -fintrinsic-modules-path /usr/local/include -fintrinsic-modules-path /usr/local/include/gfortran -fintrinsic-modules-path /usr/local/lib/gfortran/modules -L/usr/local/lib -L/usr/local/lib64 -fuse-ld=bfd -DTHREADSAFEIO -static -pthread -Wall -fbacktrace -ffpe-trap=invalid,zero,overflow -fdump-core -g]:CFLAGS[-fopenmp -DSTATIC -DBUILDPATH='./work/build' -I./source/ -I./work/build/ -fuse-ld=bfd -g -DOFDLOCKS -DPROCPS -DOFDAVAIL -DGIT2UNAVAIL]:CPPFLAGS[-fopenmp -DSTATIC -DBUILDPATH='./work/build' -I./source/ -I./work/build/ -fuse-ld=bfd -I/usr/local/include/libqhullcpp -g -DOFDLOCKS -DPROCPS -DOFDAVAIL -DANNAVAIL -DQHULLAVAIL -DMATHEVALAVAIL -DGIT2UNAVAIL]:FCCOMPILER_VERSION[Using built-in specs. COLLECT_GCC=gfortran COLLECT_LTO_WRAPPER=/usr/local/gcc-12/libexec/gcc/x86_64-pc-linux-gnu/12.4.1/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: ../gcc-12-source/gcc-12-20240801/configure --enable-languages=c,c++,fortran --enable-checking=release --disable-libstdcxx-pch --enable-libgomp --enable-lto --enable-gold --with-plugin-ld=gold --prefix=/usr/local/gcc-12 Thread model: posix Supported LTO compression algorithms: zlib gcc version 12.4.1 20240801 (GCC) ]:CCOMPILER_VERSION[Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/local/gcc-12/libexec/gcc/x86_64-pc-linux-gnu/12.4.1/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: ../gcc-12-source/gcc-12-20240801/configure --enable-languages=c,c++,fortran --enable-checking=release --disable-libstdcxx-pch --enable-libgomp --enable-lto --enable-gold --with-plugin-ld=gold --prefix=/usr/local/gcc-12 Thread model: posix Supported LTO compression algorithms: zlib gcc version 12.4.1 20240801 (GCC) ]:CPPCOMPILER_VERSION[Using built-in specs. COLLECT_GCC=g++ COLLECT_LTO_WRAPPER=/usr/local/gcc-12/libexec/gcc/x86_64-pc-linux-gnu/12.4.1/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: ../gcc-12-source/gcc-12-20240801/configure --enable-languages=c,c++,fortran --enable-checking=release --disable-libstdcxx-pch --enable-libgomp --enable-lto --enable-gold --with-plugin-ld=gold --prefix=/usr/local/gcc-12 Thread model: posix Supported LTO compression algorithms: zlib gcc version 12.4.1 20240801 (GCC) ] MM: <- Done task: report
What operating system are you running Galacticus on?
Linux
How did you obtain Galacticus?
Pre-built executable
Relevant error message output
Parameter file that causes this error