search

galacticwarrior9 / IslamBot

A Discord bot that supports Qur'an, hadith, prayer times, tafsir and more.
GNU General Public License v3.0
87 stars 36 forks source link

Update to discord.py 2.0 and drop text command support #56

Closed galacticwarrior9 closed 1 year ago

galacticwarrior9 commented 1 year ago

This PR updates the bot to discord.py 2.0, adding support for auto-completions, ephemeral messages and select menus. It also removes text command support due to Discord making message content a privileged intent (closes #51).

itzmk21 commented 1 year ago

@galacticwarrior9 Is having autocomplete for Surah names (similar to how /dua does it) a good idea? Since doing /quran surah: 24 would say No options match your search which might lead the user to believe surah numbers aren't possible, despite it actually still working with numbers.

galacticwarrior9 commented 1 year ago

I think it would work if the auto-complete only begins if (1) the user has typed at least one character and (2) said character is not a number

galacticwarrior9 commented 1 year ago

..although I think that would still give the "No options match your search" pop-up

itzmk21 commented 1 year ago

..although I think that would still give the "No options match your search" pop-up

Yeah it gives it, regardless of even if you've typed a single character