search

galacticwarrior9 / IslamBot

A Discord bot that supports Qur'an, hadith, prayer times, tafsir and more.
GNU General Public License v3.0
89 stars 37 forks source link

Display full names of translations in quran / rquran command's autocomplete #69

Closed msabur closed 1 year ago

msabur commented 1 year ago

Fixes #65

Note: An issue is that sometimes multiple translations have the same name. This issue also exists in Quran.com's data (https://api.quran.com/api/v4/resources/translations). For example, "Ruwwad Center" appears as the name for translations 206, 220, and 228.

galacticwarrior9 commented 1 year ago

Would it be possible to add a distinguisher to the duplicate names, even if that diverges from the name supplied by the API? e.g. Ruwwad Center (English), Ruwwad Center (Vietnamese), etc

itzmk21 commented 1 year ago

This is really good! Jazakallah for sorting it out.

Btw does it also solve #66, or have the new translations not been added yet?

msabur commented 1 year ago

This is really good! Jazakallah for sorting it out.

Btw does it also solve #66, or have the new translations not been added yet?

No; I thought having two changes in one PR would be messy. But I can add them here if that’s better.

Would it be possible to add a distinguisher to the duplicate names, even if that diverges from the name supplied by the API? e.g. Ruwwad Center (English), Ruwwad Center (Vietnamese), etc

Done.