search

galaipa / SimpleRename

Item editing bukkit plugin
GNU General Public License v2.0
9 stars 18 forks source link

Interferences with Silence Mobs plugin #42

Closed galaipa closed 4 years ago

galaipa commented 4 years ago

https://www.spigotmc.org/resources/silence-mobs.75749/

It could also be interfering with other similar plugins

galaipa commented 4 years ago

This is related to the &r formatting code the plugin adds by default.

niqoar commented 4 years ago

Hello! When you use a label with the name "Silence Me" on a mob, it should automatically be renamed to "Silenced" and not play any sounds. With "SimpleRename" installed, the mob is never renamed to "Silenced" so the plugin does not work.

Without "SimpleRename" it works correctly. There are also no errors in the console

niqoar commented 4 years ago

Sorry, this was fixed with SimpleRename v13.0. I didn't realize I was on 12.2.

galaipa commented 4 years ago

No, it's not. A bug in v13.0 makes it work, but it won't if I release the new fixed version. The problem is the following: By default when you rename an item, the game shows it in Italics. This doesn't look very nice, so a while a go I decided to add the &r formatting code at the beginning every time a renaming is performed. So, when you rename the name tag, the name is &rSilence Me, and the plugin doesn't detect it. I think I can add configuration flag to disable this feature. What do you think?

niqoar commented 4 years ago

That sounds good!

galaipa commented 4 years ago

Fixed! I plan to release new version soon