galaipa / SuperBuildBattle2

Recoded version of SuperBuildBattle
7 stars 8 forks source link

Multi-Arena issues #24

Open CrypticCabub opened 8 years ago

CrypticCabub commented 8 years ago

Hey there! First some basic information: Spigot version 1.8.8 using offline mode (bungeecord IP forward or whatever it's called so UUID should still be reliable) SuperBuildBattle version: 9.0 (latest one on bukkit page) a few extra setup details: -multiple plugins including Essentials, WorldGuard, WorldBorder, Logblock, Vault, ChestShop, and others that should have no impact on BuildBattle -4 Build Battle arenas configured with near identical settings (2-8 players, 15 minutes, 60 seconds vote time, just different play regions)

I've recently setup your plugin on my server and have run into multiple issues both with setup and with actually playing the game.

First of all arena setup appears to be not properly "forgetting" the last arena you setup. I create arena 1 and all goes well, but then I create arena 2 and the play regions I get include all of arena 1 plus the new ones I just set (best guess is that a List is not being properly cleared -- maybe a pass-by-reference instead of pass-by-value issue). I believe there may be a similar issue when editing an area but have not tested enough to say for certain.

I worked around this first issue by restarting the server after each arena config (forcing the arena builder to dump all it's data and start afresh) and that seemed to get the arenas to save properly

I've also been having multiple issues with those arenas now that they are running. I have not had the time to heavily test and come up with detailed specific break points, but I do have some information: I keep getting reports that people cannot use the menu book, or are teleporting into an arena that is currently in use and resetting somebody's work half way into a round (and now 2 people are using the same region for different games). going off feel it seems like the plugin is, again, not properly dropping data and resetting after a game and/or somehow allowing an arena to be loaded and started while it is already in use (Arena 1 is in-game, Arena 2 is starting, and then Arena 3 starts up but for some reason loads up and plays in Arena 1's configured area)

a 3rd smaller issue is that /bb removetopic Creeper did not work when I ran it. It said it worked but didn't actually remove the topic (I ended up deleting the topic directly in the save data)

and finally some feedback on the arena setup UI: -Can left-click reduce the amount of items in the stack? When I've accidently clicked too many times I've restarted setup because it's pretty unclear whether or not I can just dump items from the stack and things work properly. They feel like UI elements backing a variable somewhere and not the actual variables themselves. -When you edit an arena, could the setup blocks be given to you in the amounts that the arena is currently setup for. It's very unclear what the current arena settings are and also adds to the unease with the first bug I talked about with arenas saving in some cases 24 play areas when I had set the max players to 8.

The plugin feels nice and streamlined and the setup UI is interesting to say the least (chat covers up item names on my resolution regularly so it's a little unwieldy at times). Lobby system is streamlined though might be nice to be able to join/spectate a specific arena. all in all I like your plugin and would love to see it running smoothly.

Please let me know if I can provide any more help/information -CrypticCabub

CrypticCabub commented 8 years ago

Also, where can I get that 9.5 version mentioned on one of the latest pushes? like I said all I have is 9.0 because that's what's available on the bukkit site

Thanks! -CrypticCabub

galaipa commented 8 years ago

Thanks! You were right, some lists weren't cleared correctly when finishing the setup! I will try to fix the other bugs as soon as I can

CrypticCabub commented 8 years ago

glad I could help

Once you have them fixed could you supply me with the latest Jar? I tried to clone the git repo and compile it myself but all my experience is with Gradle and I was struggling to get it to compile properly (or am I just wasting my time trying to make a build.gradle for it when there is a command to compile with raw Java?)

Thanks! -CrypticCabub

galaipa commented 8 years ago

Hi! I just compile it using the Build Project button in NetBeans. You don't need to set anything special. You just have to add de dependencies: WorldEdit,WorldGuard,Vault,PlayerPoints,Multiverse-Core and Spigot 1.8.8

If you want I can help you doing it from skype.

CrypticCabub commented 8 years ago

Sorry it took so long! I've been busy and just now got around to testing your updates

I've opened a new ticket with my findings :). And yes we could get in touch via Skype If that's helpful with feedback. Just let me know