galan / packtag

A JSP Taglib for delivering minified, combined and gzip-compressed resources (JavaScript and CSS).
Apache License 2.0
24 stars 13 forks source link

TLD uri mismatch #1

Closed clottes closed 10 years ago

clottes commented 10 years ago

the packtag.tld (inside jar version 3.9) uri declaration refers to: https://github.com/d8bitr/packtag

which results in the following error: The absolute uri: http://packtag.sf.net cannot be resolved in either web.xml or the jar files deployed with this application

Switching taglib declaration to: <%@ taglib uri="https://github.com/d8bitr/packtag" prefix="pack" %> will fix this, but then it's inconsistent with the releases location in your repository, which is under: net/sf/pcaktag as well as the groupId and everything else points to "net.sf.packtag"

galan commented 10 years ago

Thanks for pointing this out, I have just released 3.10 which should have solved this

clottes commented 10 years ago

Daniel, I have been using LABJS for deferred javascript loading, using this in conjunction with packtag had obviously created problems, as packtag always creates the script tags.... On my branch I have created a attribute labjs to adjust for this and print out in labjs loading style....

However I propose adding an attribute such as "tag" defaults to true, but if false omits everything but the source filename as output. (this way it would be supportable in any way possible, not just labjs). Or perhaps we should call it onlySrc, and default to 'false'

let me know what you think and I'll clean up the code I did and change it to an agreed upon functionality.

Sincerely, Chris Lottes

On Sat, Mar 22, 2014 at 5:46 AM, Daniel Galán y Martins < notifications@github.com> wrote:

Closed #1 https://github.com/d8bitr/packtag/issues/1.

— Reply to this email directly or view it on GitHubhttps://github.com/d8bitr/packtag/issues/1 .

galan commented 10 years ago

Hi Chris, can you please create a new issue to keep things seperate? Beside of this it seems like an interesting use-case. Best Daniel

galan commented 10 years ago

Just in case you don't find the project, my user name changed, new project link is https://github.com/galan/packtag