galatea-associates / fuse-test-data-gen

Repository for the Galatea internal data generator tool, used for generating domain data for POCs
0 stars 0 forks source link

Remove batch_size_calc.py #223

Closed WilfGala closed 4 years ago

WilfGala commented 4 years ago

Issue Description

The file batch_size_calc.py is no longer used in any way, since it was responsible for estimating the batch size (or job size) or objects from the Tampa POC (swap contracts, swap positions etc). These have been deprecated from the MVP so this file is redundant and can be removed.

Note: this closes #63

Design

Delete the file batch_size_calc.py and ensure any references to it are removed (eg in import statements - it is not currently used in any actual functionality).

app.py

in process_object_factory, remove the call to object_factory.set_batch_size() on line 83 since this should take place inside init of Creatable

creatable.py

remove the set_batch_size method, and replace with an assignment of the relevant value in init taken from the config like so:

class Creatable
    def __init__(self, factory_args, shared_args):
        # existing attribute assignments ....
        self.batch_size = shared_args['pool_job_size']

Documentation Changes

N/A

Test Evidence

All existing tests and output should be as expected

Validation in Develop All existing tests and output should be as expected