search

galatolofederico / manim-presentation

Tool for live presentations using manim
GNU General Public License v3.0
163 stars 18 forks source link

Bad quality of presentation with --fullscreen flag #15

Open torannn opened 3 years ago

torannn commented 3 years ago

image I did a comparison about the quality of manim presentation with the --fullscreen flag. In the first picture, I rendererd a manim scene with manim -qh example.py and then ran it with manim_presentation --fullscreen example. As we can see in the 1st picture, the quality is not so high (it's bad as low-quality rendering).

Then, I tried running without --fullscreen, the quality of the scene turn back to high quality (but lost the ability to be fullscreen). Seems like when doing the full-screen, the presentation has been scaled down to fit the screen, and cause this bad quality. image

Is there any way to fix this?

galatolofederico commented 3 years ago

Hi, currently manim presentation is using @glatteis full screen implementation. I was trying to have a real full screen working but is more challenging that it seems. As soon as i will have some spare time i'll try to fix this

jeertmans commented 2 years ago

Hello ! I managed to fix this issue on Windows. On Linux, the quality never downgraded with --fullscreen flag. Maybe I can propose a PR?

AnonymoZ commented 2 years ago

@jeertmans Please do!! And on windows if you can! 🙏 It's such a bummer this bug!

jeertmans commented 2 years ago

@AnonymoZ I already have a fix that also work on Windows, I am planning to have it pushed by the next three weeks. Due to the seemingly inactivity of this repo, I decided to work on my own fork, on which I plan to commit this fix as well as others. See here.

galatolofederico commented 2 years ago

Hey @AnonymoZ @jeertmans unfortunately i do not have windows nor access to a windows computer to debug this issue. If you open a PR i will be happy to merge your fix.